Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add donate functionality #9

Open
AndyGaskell opened this issue Sep 27, 2018 · 4 comments
Open

Add donate functionality #9

AndyGaskell opened this issue Sep 27, 2018 · 4 comments
Assignees
@AndyGaskell
Labels
enhancement help wanted question

Comments

@AndyGaskell
Copy link
Contributor

No description provided.

@AndyGaskell
Copy link
Contributor Author

AndyGaskell commented Sep 27, 2018 •
edited
Loading

57n_1

57n_2

57n_3

57n_4

@AndyGaskell AndyGaskell mentioned this issue Sep 27, 2018
Merged
AndyGaskell added a commit that referenced this issue Sep 27, 2018
@AndyGaskell
Merge pull request #8 from AndyGaskell/master
ac7010e 
Mainly new donate page

Re Add donate functionality #9
@AndyGaskell AndyGaskell mentioned this issue Sep 27, 2018
Merged
@AndyGaskell
Copy link
Contributor Author

Once peer reviewed we can switch in the Stripe live credentials

@AndyGaskell AndyGaskell self-assigned this Sep 27, 2018
@AndyGaskell AndyGaskell mentioned this issue Sep 27, 2018
Merged
@AndyGaskell
Copy link
Contributor Author

Hey @Nordln what do you think?

It's on a staging server if you want to try it out, just message me for details.

We could...

  • Swap in the live stripe details, and add it to the menu
  • Swap in the live stripe details, and not add it to the menu, so it's a bit hidden

@AndyGaskell
Copy link
Contributor Author

AndyGaskell commented May 14, 2019 •
edited
Loading

Just had a chat on IRC about this.

@Hibby noticed that it doesn't check the validity of the email address. I would kinda think Stripe would catch that, but apparently not. I'll add in some basic @.* type validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndyGaskell AndyGaskell

Labels
enhancement help wanted question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndyGaskell