Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: ZKP secret phrase verifier #321

Merged
merged 27 commits into from
Aug 8, 2023
Merged

Release: ZKP secret phrase verifier #321

merged 27 commits into from
Aug 8, 2023

Conversation

yu23ki14
Copy link
Member

@yu23ki14 yu23ki14 commented Aug 5, 2023

  • ZKPによるあいことばの認証機能

@vercel
Copy link

vercel bot commented Aug 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mint-rally ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 2:51pm
mintrally ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 2:51pm

@yawn-c111
Copy link
Collaborator

@yu23ki14
遅くなってしまってすみません:pray:
verifyProof() 周辺のrequireを拝見したところ、verifyの有無について想定されていたような確認が行われているように思いました!

SecretPhraseVerifier.solverifyProof() のassemblyの中からreturnされたbool値を、MintNFT.solverifySecretPhrase() から canMint() に引き渡し、そこでrequireによってbool値がtrueかfalseかでリバートががかかっているため、コントラクト間をまたいでも問題なくリバートされると思います。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants