Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vansh.dino.icu #1057

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Add vansh.dino.icu #1057

merged 4 commits into from
Feb 12, 2024

Conversation

lowkeyvansh
Copy link
Contributor

@lowkeyvansh lowkeyvansh commented Jan 27, 2024

Using dino.icu subdomain for personal website!

@lowkeyvansh lowkeyvansh requested review from a team as code owners January 27, 2024 15:28
Copy link
Contributor

@reesericci reesericci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CNAME records like this don't support URL paths, they aren't like website redirects.

You should go into the Pages settings of the github repo, and connect your dino.icu domain as a custom domain. Here's docs that explain how to do that better:

https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site

@lowkeyvansh
Copy link
Contributor Author

Done!

@reesericci
Copy link
Contributor

The commit hasn't been updated to reflect that, it should match what it says in the github pages settings under the custom domain

@lowkeyvansh
Copy link
Contributor Author

guLiO31

i have updated it in github pages settings! any suggestions on how to fix this?

dino.icu.yaml Outdated
vansh:
- ttl: 1
type: CNAME
value: lowkeyvansh.github.io/web.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the "/web" from this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated^

Copy link
Contributor

@reesericci reesericci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@reesericci reesericci changed the title add vansh.dino.icu Add vansh.dino.icu Feb 12, 2024
@reesericci reesericci merged commit caf5228 into hackclub:main Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants