-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vansh.dino.icu
#1057
Add vansh.dino.icu
#1057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CNAME records like this don't support URL paths, they aren't like website redirects.
You should go into the Pages settings of the github repo, and connect your dino.icu domain as a custom domain. Here's docs that explain how to do that better:
Done! |
The commit hasn't been updated to reflect that, it should match what it says in the github pages settings under the custom domain |
dino.icu.yaml
Outdated
vansh: | ||
- ttl: 1 | ||
type: CNAME | ||
value: lowkeyvansh.github.io/web. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove the "/web" from this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Using dino.icu subdomain for personal website!