Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ansh.hackclub.com #1003

Merged
merged 23 commits into from
Nov 14, 2023
Merged

add ansh.hackclub.com #1003

merged 23 commits into from
Nov 14, 2023

Conversation

ansh3108
Copy link
Member

No description provided.

grymmy
grymmy previously requested changes Nov 13, 2023
Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we try to keep this file in alphabetical order - please move this to the appropriate location

ansh:
- ttl: 1
type: CNAME
value: ansh3108.github.io/website/.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not a valid CNAME entry

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide should help you set a correct one up

dino.icu.yaml Outdated Show resolved Hide resolved
Co-authored-by: Krish Gupta <[email protected]>
dino.icu.yaml Outdated Show resolved Hide resolved
Co-authored-by: Krish Gupta <[email protected]>
@devramsean0 devramsean0 dismissed grymmy’s stale review November 14, 2023 18:08

Outdated (moved to different file)

Copy link
Member

@devramsean0 devramsean0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
This now appears to be correct!

@devramsean0
Copy link
Member

Merging Now!

@devramsean0 devramsean0 merged commit 0f90368 into hackclub:main Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants