Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add xgsont FS XGS-ONU-25-20NI #262

Merged
merged 18 commits into from
Aug 21, 2023
Merged

add xgsont FS XGS-ONU-25-20NI #262

merged 18 commits into from
Aug 21, 2023

Conversation

YuukiJapanTech
Copy link
Contributor

added FS XGS-ONU-25-20NI (CA8271x)
Port the GitHub CA8271x(https://github.com/YuukiJapanTech/CA8271x) article.

@YuukiJapanTech
add FS xgsont XGS-ONU-25-20NI
87e56eb 
added FS XGS-ONU-25-20NI (CA8271x)
@YuukiJapanTech YuukiJapanTech temporarily deployed to external August 10, 2023 08:35 — with GitHub Actions Inactive
@alvgalrus
Copy link
Contributor

Thanks @YuukiJapanTech ! I'll add some details to your contribution during the day as long as I find more things. For example, I have a newer software version than yours.

@github-actions
Copy link

Preview of the website obtained from the PR: https://d10f9d83.hack-gpon-preview.pages.dev

@nanomad
Copy link
Contributor

nanomad commented Aug 10, 2023

@YuukiJapanTech the "ONT fs.com" link in the sidebar under XGS PON doesn't link to the right page
@simonebortolin Shouldn't we just leave FS.com?

nanomad
nanomad requested changes Aug 10, 2023
View reviewed changes
_ont_xgs/ont-fs-XGS-ONU-25-20NI.md Outdated Show resolved Hide resolved
@simonebortolin simonebortolin temporarily deployed to external August 10, 2023 10:46 — with GitHub Actions Inactive
@github-actions
Copy link

Preview of the website obtained from the PR: https://6c78e909.hack-gpon-preview.pages.dev

@simonebortolin simonebortolin temporarily deployed to external August 10, 2023 10:49 — with GitHub Actions Inactive
@simonebortolin simonebortolin temporarily deployed to external August 10, 2023 10:52 — with GitHub Actions Inactive
@simonebortolin
Copy link
Contributor

@nanomad

@YuukiJapanTech the "ONT fs.com" link in the sidebar under XGS PON doesn't link to the right page
@simonebortolin Shouldn't we just leave FS.com?

I fixed the problem, it was a series of 3 problems fixed in the commits.

@github-actions
Copy link

Preview of the website obtained from the PR: https://397d0bff.hack-gpon-preview.pages.dev

@simonebortolin
Copy link
Contributor

@YuukiJapanTech this is the template for the generic ONU/ONT page: https://github.com/hack-gpon/hack-gpon.github.io/blob/main/_ont/ont-template.md please try to respect it as much as possible (order, titles, etc.)

@YuukiJapanTech
Copy link
Contributor Author

@simonebortolin
Thanks for sharing the template!
sorry, overlooked it. I will modify it to be compliant.

@alvgalrus
Copy link
Contributor

@YuukiJapanTech I created a PR against your branch with versions and the CLI command tree. Do you mind merging it when you have some time? Thank you.

@simonebortolin
Copy link
Contributor

simonebortolin commented Aug 10, 2023 •
edited
Loading

@alvgalrus if you want to do a shared PR, you are more likely to have both write permissions in the same repo, because it is possible that we also ask for changes to non-@YuukiJapanTech things.

@YuukiJapanTech
Merge pull request #1 from alvgalrus/CA8271x
7e71170 
Add versions and command tree to ont-fs-XGS-ONU-25-20NI
@YuukiJapanTech YuukiJapanTech temporarily deployed to external August 11, 2023 03:59 — with GitHub Actions Inactive
@YuukiJapanTech
Conforms to template
4397cc3 
Conforms to ont template
@YuukiJapanTech YuukiJapanTech temporarily deployed to external August 11, 2023 07:46 — with GitHub Actions Inactive
@YuukiJapanTech
Copy link
Contributor Author

Hi, I modified it to comply with the template, please check it.
(and CLI tree PR added, thanks)

Added @alvgalrus as a collaborator for CA8271x.

@simonebortolin
Copy link
Contributor

In an hour I'll look at it

@github-actions
Copy link

Preview of the website obtained from the PR: https://33ccd36a.hack-gpon-preview.pages.dev

@github-actions
Copy link

Preview of the website obtained from the PR: https://2dd4978b.hack-gpon-preview.pages.dev

nanomad
nanomad reviewed Aug 11, 2023
View reviewed changes
_ont_xgs/ont-fs-XGS-ONU-25-20NI.md Show resolved Hide resolved
_ont_xgs/ont-fs-XGS-ONU-25-20NI.md Outdated Show resolved Hide resolved
@YuukiJapanTech YuukiJapanTech temporarily deployed to external August 18, 2023 10:58 — with GitHub Actions Inactive
@YuukiJapanTech
Copy link
Contributor Author

@nanomad thanks, fixed it.

@github-actions
Copy link

Preview of the website obtained from the PR: https://9741e6a5.hack-gpon-preview.pages.dev

@YuukiJapanTech YuukiJapanTech temporarily deployed to external August 18, 2023 11:09 — with GitHub Actions Inactive
@YuukiJapanTech
Copy link
Contributor Author

@simonebortolin Fixed. please make sure.

@github-actions
Copy link

Preview of the website obtained from the PR: https://f5e5f5f5.hack-gpon-preview.pages.dev

simonebortolin
simonebortolin previously approved these changes Aug 18, 2023
View reviewed changes
_ont_xgs/ont-fs-XGS-ONU-25-20NI.md Outdated Show resolved Hide resolved
@simonebortolin
Copy link
Contributor

sorry it's very long and I don't always see things straight away

@alvgalrus
Copy link
Contributor

alvgalrus commented Aug 19, 2023 •
edited
Loading

I added the latest changes from code review to a PR and some more things I saw while editing the file. Waiting for @YuukiJapanTech to approve the changes to this PR's branch since it's protected.

@YuukiJapanTech
Merge pull request #2 from YuukiJapanTech/CA8271x-pr
d52f145 
Formatting and spelling from code review
@YuukiJapanTech YuukiJapanTech temporarily deployed to external August 19, 2023 11:12 — with GitHub Actions Inactive
@github-actions
Copy link

Preview of the website obtained from the PR: https://11de782a.hack-gpon-preview.pages.dev

@simonebortolin
Copy link
Contributor

@nanomad or @ErnyTech give one last check, then you can merge

@YuukiJapanTech
Copy link
Contributor Author

ok, thanks for check.

@simonebortolin simonebortolin merged commit b953ce1 into hack-gpon:main Aug 21, 2023
@simonebortolin
Copy link
Contributor

@YuukiJapanTech @alvgalrus thank you very much

@simonebortolin simonebortolin mentioned this pull request Sep 7, 2023
Open
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvgalrus alvgalrus alvgalrus left review comments

@simonebortolin simonebortolin simonebortolin approved these changes

@nanomad nanomad nanomad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YuukiJapanTech @alvgalrus @nanomad @simonebortolin