Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish declaration maps so goto definition works properly #47

Closed
wants to merge 1 commit into from

Conversation

natdempk
Copy link

@natdempk natdempk commented Apr 4, 2024

👋

I was trying to use this library a bit and understand the the types/source. It is a bit hard in VSCode because jump to definition takes you to a TS declaration file or a compiled JS file today.

This PR adds the TS compiler option to publish declaration maps which fixes this issue, making developer experience better: https://www.typescriptlang.org/tsconfig#declarationMap

It would maybe be nice to cut a release with these enabled if its not a hassle so they actually get published.

Copy link

changeset-bot bot commented Apr 4, 2024

⚠️ No Changeset found

Latest commit: 1fc5b38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
island-ai-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 0:50am

@roodboi
Copy link
Contributor

roodboi commented Apr 7, 2024

I'm generally for this update. There were some issues with tsup not respecting the option, and it required some workaround, either running it with tsc post build or using some other set of options—I never dug in too deep.

did you confirm this working with a build?

egoist/tsup#885
there's a few threads but this one seems to have some somewhat recent activity

@roodboi
Copy link
Contributor

roodboi commented Apr 22, 2024

There are some issues with creating declaration maps with tsup - going to close, but if you want to open an issue or take a stab at figuring out a reasonable workaround, happy to take a look - but this is going to require some build updates to get working

@roodboi roodboi closed this Apr 22, 2024
@natdempk
Copy link
Author

👍 Thanks, yeah no worries. Also looked at the tsup issue and workarounds a bit here and it seemed like support was non-trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants