Values first approach #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosvm13
reviewed
Dec 21, 2023
src/pykx/pandas_api/pandas_meta.py
Outdated
| @api_return | ||
| def values(self, skipna = True, numeric_only = False): | ||
| tab = self | ||
| return q('{[table] flip value flip table}', tab) |
There was a problem hiding this comment.
Maybe something like this is more efficient:
return q("value peach", tab)
tests/test_pandas_api.py
Outdated
| col3 = q('10?`x`y`z`1`2`3') | ||
| matrix = q('{[r1; r2; r3] flip enlist[r1; r2; r3]}', col1, col2, col3) | ||
| tab = q('{[price; sym; id] ([]p: price; s: sym; i: id)}', col1, col2, col3) | ||
| assert tab.values().py() == matrix.py() |
There was a problem hiding this comment.
I would do the test the way I told you before:
q_table = tab
pandas_table = tab.pd()
q("~", kx.toq(pandas_table.values), q_table.values())
github-actions
bot
added
the
documentation
marcosvm13
reviewed
Jan 11, 2024
| @@ -1287,7 +1326,9 @@ | |||
| { | |||
| "cell_type": "markdown", | |||
| "id": "35062560", | |||
| "metadata": {}, | |||
| "metadata": { | |||
| "metadata": { | ||
| "scrolled": false | ||
| }, | ||
| "metadata": {}, |
| @@ -257,6 +262,7 @@ def sum(self, axis=0, skipna=True, numeric_only=False, min_count=0): | |||
| min_count | |||
| ), cols) | |||
|
|
|||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please go the the
Previewtab and select the appropriate sub-template: