Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement notification response handling #156

Merged

Conversation

owengretzinger
Copy link
Collaborator

@owengretzinger owengretzinger commented Jan 17, 2025

TL;DR

Added notification response functionality allowing users to accept/reject friend requests and habit invites.

Screen.Recording.2025-01-17.at.1.07.37.PM.mov

What changed?

  • Created useRespondToNotification mutation hook to handle notification responses
  • Added empty state message when no notifications exist
  • Implemented notification confirmation and deletion in the NotificationCard component
  • Added mock data for habit completions to support testing

How to test?

  1. Navigate to the Notifications tab
  2. Try accepting a friend request - verify the friendship is established
  3. Try accepting a habit invite - verify you're added as a participant
  4. Try rejecting any notification - verify it's removed from the list
  5. Clear all notifications - verify the empty state message appears

@owengretzinger owengretzinger changed the title feat: respond to notification functionality feat: implement notification response handling Jan 17, 2025
@owengretzinger owengretzinger marked this pull request as ready for review January 17, 2025 18:09
@graphite-app graphite-app bot requested a review from AnkushSarkar10 January 17, 2025 18:09
Copy link

graphite-app bot commented Jan 17, 2025

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (01/17/25)

1 reviewer was added to this PR based on Owen Gretzinger's automation.

@owengretzinger owengretzinger force-pushed the 01-12-feat_notification_page branch from a0f664b to 76b6087 Compare January 27, 2025 07:47
@owengretzinger owengretzinger force-pushed the 01-17-feat_respond_to_notification_functionality branch from 492d5b1 to a423843 Compare January 27, 2025 07:47
@owengretzinger owengretzinger force-pushed the 01-12-feat_notification_page branch from 76b6087 to 3aa2f64 Compare January 27, 2025 07:54
@owengretzinger owengretzinger force-pushed the 01-17-feat_respond_to_notification_functionality branch from a423843 to e6b12dd Compare January 27, 2025 07:55
@owengretzinger owengretzinger force-pushed the 01-12-feat_notification_page branch 2 times, most recently from 4d8ea59 to 3e713eb Compare January 27, 2025 08:00
@owengretzinger owengretzinger force-pushed the 01-17-feat_respond_to_notification_functionality branch from e6b12dd to adb931f Compare January 27, 2025 08:00
@owengretzinger owengretzinger changed the base branch from 01-12-feat_notification_page to graphite-base/156 January 27, 2025 08:03
@owengretzinger owengretzinger force-pushed the 01-17-feat_respond_to_notification_functionality branch from adb931f to f05f966 Compare January 27, 2025 08:04
@owengretzinger owengretzinger changed the base branch from graphite-base/156 to main January 27, 2025 08:04
@owengretzinger owengretzinger force-pushed the 01-17-feat_respond_to_notification_functionality branch from f05f966 to b427b7a Compare January 27, 2025 08:04
@owengretzinger owengretzinger merged commit 3581326 into main Jan 27, 2025
2 checks passed
Copy link
Collaborator Author

Merge activity

  • Jan 27, 3:08 AM EST: A user merged this pull request with Graphite.

@owengretzinger owengretzinger deleted the 01-17-feat_respond_to_notification_functionality branch January 27, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants