Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes mesosize and cfize #9557

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Removes mesosize and cfize #9557

merged 3 commits into from
Jan 10, 2025

Conversation

jasonheath
Copy link
Contributor

Removes mesosize and cfize functionality and references where appropriate. For example, removes plan files and source explicitly relating to those but doesn't change text fixtures or changelogs.

There is a section of BUILDING.md that uses cloud foundry as an example that will need to be addressed but I didn't want to come up with an alternate example yet. Others should feel free to remove that section or rewrite it as they feel inclined.

Also, I probably missed something else but this is a pretty good scrubbing that is passing the verify pipeline and has the commands gone from the hab binary.

[admin@jah-wah | ~/Development/habitat/target/debug | jah/rm-mesos-and-cloud-foundry|u=]
$ ./hab pkg export
hab-pkg-export 2.0.16
Exports the package to the specified format

USAGE:
    hab pkg export <SUBCOMMAND>

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

SUBCOMMANDS:
    container    Container exporter
    help         Prints this message or the help of the given subcommand(s)
    tar          Tar exporter

@agadgil-progress: Added you as a reviewer because this probably interacts with your CLAP work a bit

Signed-off-by: Jason Heath <[email protected]>
@github-actions github-actions bot added the Documentation Flags an issue / PR for attention by the technical documentation team label Jan 9, 2025
Copy link

netlify bot commented Jan 9, 2025

👷 Deploy Preview for chef-habitat processing.

Name Link
🔨 Latest commit b95154d
🔍 Latest deploy log https://app.netlify.com/sites/chef-habitat/deploys/678167ee784d0f0009175d6d

@jasonheath jasonheath marked this pull request as ready for review January 9, 2025 20:44
@jasonheath jasonheath requested a review from IanMadd as a code owner January 9, 2025 20:44
Copy link
Contributor

@mwrock mwrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels good to look at!

@jasonheath
Copy link
Contributor Author

@mwrock: Made one last change if you can eyeball the BUILDING.md

@agadgil-progress: Planning on merging this Monday. I don't think this meaningfully impacts you but still highlighting it.

Copy link
Contributor

@mwrock mwrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't see any issue with merging now.

Copy link
Contributor

@IanMadd IanMadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs suggestions

components/docs-chef-io/content/habitat/install_faq.md Outdated Show resolved Hide resolved
components/docs-chef-io/content/habitat/pkg_exports.md Outdated Show resolved Hide resolved
components/docs-chef-io/content/habitat/pkg_exports.md Outdated Show resolved Hide resolved
Signed-off-by: Jason Heath <[email protected]>
Co-authored-by: Ian Maddaus <[email protected]>
@jasonheath jasonheath force-pushed the jah/rm-mesos-and-cloud-foundry branch from ddc6c04 to b95154d Compare January 10, 2025 18:33
@jasonheath
Copy link
Contributor Author

Going ahead and merging per Matt's feedback and Ian's doc review.

@jasonheath jasonheath merged commit d4cb205 into main Jan 10, 2025
11 checks passed
@jasonheath jasonheath deleted the jah/rm-mesos-and-cloud-foundry branch January 10, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Flags an issue / PR for attention by the technical documentation team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants