-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes mesosize and cfize #9557
Conversation
Signed-off-by: Jason Heath <[email protected]>
👷 Deploy Preview for chef-habitat processing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels good to look at!
Signed-off-by: Jason Heath <[email protected]>
@mwrock: Made one last change if you can eyeball the BUILDING.md @agadgil-progress: Planning on merging this Monday. I don't think this meaningfully impacts you but still highlighting it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I don't see any issue with merging now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs suggestions
Signed-off-by: Jason Heath <[email protected]> Co-authored-by: Ian Maddaus <[email protected]>
ddc6c04
to
b95154d
Compare
Going ahead and merging per Matt's feedback and Ian's doc review. |
Removes mesosize and cfize functionality and references where appropriate. For example, removes plan files and source explicitly relating to those but doesn't change text fixtures or changelogs.
There is a section of BUILDING.md that uses cloud foundry as an example that will need to be addressed but I didn't want to come up with an alternate example yet. Others should feel free to remove that section or rewrite it as they feel inclined.
Also, I probably missed something else but this is a pretty good scrubbing that is passing the verify pipeline and has the commands gone from the hab binary.
@agadgil-progress: Added you as a reviewer because this probably interacts with your CLAP work a bit