Studio can build against downgraded channels #9282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-habitat processing.
|
sajjaphani
approved these changes
Jul 22, 2024
components/hab/src/cli/hab/pkg.rs
Outdated
| @@ -348,6 +348,13 @@ pub struct PkgBuild { | |||
| /// Uses a Dockerized Studio for the build | |||
| #[structopt(name = "DOCKER", short = "D", long = "docker")] | |||
| docker: bool, | |||
| /// Channel used to retrieve plan dpendencies for Chef supported origins | |||
| http_proxy Sets an http_proxy environment variable inside the Studio | ||
| https_proxy Sets an https_proxy environment variable inside the Studio | ||
| no_proxy Sets a no_proxy environment variable inside the Studio | ||
| ARTIFACT_PATH Sets the source artifact cache path (\`-a' option overrides) |
There was a problem hiding this comment.
missing HAB_REFRESH_CHANNEL
| QUIET Prints less output (\`-q' flag overrides) | ||
| SRC_PATH Sets the source path (\`-s' option overrides) | ||
| VERBOSE Prints more verbose output (\`-v' flag overrides) | ||
| HAB_LICENSE Set to 'accept' or 'accept-no-persist' to accept the Habitat license |
There was a problem hiding this comment.
missing HAB_REFRESH_CHANNEL
Signed-off-by: Matt Wrock <[email protected]>
Signed-off-by: Matt Wrock <[email protected]>
Signed-off-by: Matt Wrock <[email protected]>
|
Converting this to draft until windows packages are promoted to LTS-2024. |
Signed-off-by: Matt Wrock <[email protected]>
jasonheath
added a commit
that referenced
this pull request
Dec 20, 2024
PR: #9282 COMMAND: patch test/end-to-end/test_studio_can_build_packages.ps1 \ <(diff <(git show ca4c091:test/end-to-end/test_studio_can_build_packages.ps1) \ <(git show ca4c091^:test/end-to-end/test_studio_can_build_packages.ps1)) Signed-off-by: Jason Heath <[email protected]>
jasonheath
added a commit
that referenced
this pull request
Dec 20, 2024
…ed channels" This reverts commit 22bb081.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two new environment variables to the hab-plan-build script (linux and windows):
HAB_REFRESH_CHANNELspecifies the channel used to pull dependencies forcore,chefandchef-platformorigins. The default isLTS-2024which falls back tostableif they cannot be found there.HAB_PREFER_LOCAL_CHEF_DEPSis a boolean flag which defaults to false/unset. If set, this informs the build to choose a locally installed core/chef/chef-platform dependency over the one in the remote bldr channel. This would likely be used by the packages team when building a new set of refreshed packages where they need to build many deps locally in a particular order. It would also be used in our own release pipeline when we need to pull a locally built component (like a new new studio).The
hab pkg buildcommand has a new--refresh-channelarg that is a convenience for feeding theHAB_REFRESH_CHANNELenvironment variable for a build. There is no convenience arg forHAB_PREFER_LOCAL_CHEF_DEPSbecause that will likely only be used internally.One key thing to note here is that now, unless
HAB_PREFER_LOCAL_CHEF_DEPSis set, core/chef/chef-platform deps will only ever come the remote refresh channel and they will not come from the latest locally installed package.I have removed the
IGNORE_LOCALfeature flag since this now removes the need for that flag. We only ever needed/used this forcoredeps and now we essentially use it by default. It was also never publicly documented so I don't think we need to worry about it breaking anyone.