Revert "fixes windows 7 support" #9271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-habitat processing.
|
mwrock
reviewed
Jun 5, 2024
jasonheath
force-pushed
the
jah/remove-windows-7-support
branch
3 times, most recently
from
86f0e1f to
c6f9106
Compare
|
|
@mwrock: Ready for your review again when you have time |
mwrock
approved these changes
Jun 7, 2024
|
Discussed this in Today's Master Chefs Daily Meeting and we cleared this for merging. Will highlight in our internal ticketing that we need to make sure affected external stakeholders are reminded when this is eventually released in a build. |
- reverts commit 97eff71 - addresses RUSTSEC-2020-0016 and RUSTSEC-2022-0041 Signed-off-by: Jason Heath <[email protected]>
jasonheath
force-pushed
the
jah/remove-windows-7-support
branch
from
c6f9106 to
d09e800
Compare
|
Had to resolve a couple of conflicts that arose in Cargo.lock. Seemed straight ahead, upon successful build and a bit more review I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit in this PR reverts commit 97eff71 via the git revert. Others may follow after review and discussion. Since I didn't want to fully rehab my Windows environment this morning I pushed this branch up so I could fire leverage buildkit and run the test suites against Windows. I decided to go ahead and create a draft PR for visibility in case this turns into anything.
The motivation is that one of the tasks I have to to see about addressing CHEF-12227: owning_ref vulnerable to multiple soundness issues #18. While not related to Win7 support, Matt researched and confirmed, the thought is that there is lot of discussion around CVEs, Dependabot/Github advisors, and rustsec advisors.
Part of the context around the many vulnerabilities we want to address and some of them are due to crate version pins which ripple the system in terms of what versions they pull along with them. Eliminating any pinned versions that we can eliminate so that we can reassess our list of vulnerabilities in the context of the latest versions we can leverage seems warranted.