C++ async and forasync delegate to C API #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.1 seconds is still an eternity in CPU cycles, but much less noticeable by the user than 1 second.
We want to use the C11 _Static_assert if possible (since it gives much better diagnostics), but there's a fall-back version defined as well, just in cast the C11 version isn't available. Since we already assume C++11, it seems safe to assume C11 as well.
This should eliminate some duplicate logic and simplify the C++ API. This should also eliminate some functor copies that were being caused by by-value parameter passing of user functors (see issue #17).
This should eliminate some duplicate logic and simplify the C++ API. This should also eliminate a significant number of functor copies that were caused by by-value parameter passing and captures of user functors (see issue #17).
|
Now that #16 is merged, I've rebased this PR off master. |
|
Superseded by #21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding was that we wanted the C++ API to be a thin wrapper over the C API. These changes update the C++ API for async, forasync, etc. so that most of the internal logic is delegated to the C code.
This patch should also close issue #17, since it eliminates most of the extra copies of user functors that were happening in the C++ code in the async implementation, and more especially in forasync implementation.
Note: This pull request builds on #16. You can compare the branches corresponding to the pull requests to see the diff between just #16 and this PR: cxx-cleanup-4...cxx-cleanup-5