Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JI-6710 optimize math display #312

Closed
wants to merge 1 commit into from

Conversation

devland
Copy link
Contributor

@devland devland commented Oct 8, 2024

No description provided.

@icc
Copy link
Member

icc commented Oct 8, 2024

In my testing of the content all of the slides end up with the same tooltip using this solution, I'm not sure why. But, I found another workaround by simply changing the MathDisplay observer from the container to the entire body: https://github.com/h5p/h5p-math-display/blob/fix/JI-6710-optimize-update-function-calls/src/scripts/mathdisplay.js#L95
This works because the tooltips are actually placed outside the content. Not sure how good of a practices this is though.

@icc icc closed this Oct 8, 2024
@icc icc deleted the fix/JI-6710-optimize-math-display branch October 8, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants