Accordion expand/collapse option #7
Conversation
…irst open. Multiple panels open functionality added.
|
Hi @nmillin , Code looks very good! But I found a bug:
|
…t a time" selected. - Now it will set the $expandedTitle & $expandedPanel on this case.
|
Thanks for the review tajakobsen. Please see 7436468 with a fix for this bug. Thanks. |
h5p-accordion.js
Outdated
| // Since the first panel is already open, and this is the first time through, you need to make sure $expandedTitle & $expandedPanel are set. | ||
| if (loadFirstPanel && expandCollapseOption === "expandedFirstOnly") { | ||
| self.$expandedTitle = $('#h5p-panel-link-0-0'); // Get the first panel title. | ||
| self.$expandedPanel = $('#h5p-panel-content-0-0'); // Get the first panel. |
There was a problem hiding this comment.
What if this accordion is not the first accordion on the page? Then the -0-0-part of the selectors wouldn't work.
Maybe you can check if this works:
self.$expandedTitle = self.elements[0];
self.$expandedPanel = self.elements[1];There was a problem hiding this comment.
I'm assuming there are content types that could have 2 (or more) accordions as part of a larger content type. Is that correct?
A little tweak to the code so that it will return a jQuery object instead of html.
self.$expandedTitle = $(self.elements).eq(0);
self.$expandedPanel = $(self.elements).eq(1);
Thoughts?
There was a problem hiding this comment.
Added a commit with this change.
|
This issue is tracked here: https://h5ptechnology.atlassian.net/browse/HFP-722 |
adding the ability to have all panels open, all closed, or just the first open. Multiple panels open functionality added.
This is from https://h5p.org/comment/9900. I used language that made sense to me, but I don't have strong feelings about what the labels, terms, and descriptions are.
Please let me know what you think. Thanks.
-Nate