Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename visuallyhidden to sr-only #27

Merged
merged 2 commits into from
Apr 12, 2019
Merged

rename visuallyhidden to sr-only #27

merged 2 commits into from
Apr 12, 2019

Conversation

coliff
Copy link
Member

@coliff coliff commented Apr 12, 2019

This fixes #25 and #22

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

@coliff coliff requested a review from roblarsen April 12, 2019 03:56
@coliff coliff mentioned this pull request Apr 12, 2019
4 tasks
@roblarsen roblarsen merged commit 38dd3d3 into master Apr 12, 2019
@roblarsen roblarsen mentioned this pull request Apr 12, 2019
3 tasks
@coliff coliff deleted the sr-only branch April 12, 2019 10:53
@NickColley
Copy link

Hey friends,

Visually hidden text is used by more than just screen readers, for example it can impact dictation software.

If you do decide to change this in the future it may be helpful to know that bootstrap has moved back to visually hidden for this reason.

twbs/bootstrap#31139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visuallyhidden > sr-only
3 participants