Skip to content
This repository has been archived by the owner on Feb 13, 2019. It is now read-only.

Icon Sprite needs to be CDNed #19

Open
nimbupani opened this issue Feb 21, 2012 · 6 comments
Open

Icon Sprite needs to be CDNed #19

nimbupani opened this issue Feb 21, 2012 · 6 comments
Milestone
v1.0

Comments

@nimbupani
Copy link
Member

Right now it is pointing to @jonathantneal 's domain, but ideally we should put it on a CDN.
@AaronLayton
Copy link

Do we know anyone with a CDN? or is there one you guys normally use?

@paulirish
Copy link
Member

relatedly, the image url should be referenced in the JSON payload.

@nimbupani
Copy link
Member Author

Already CDNed: https://github.com/h5bp/caniuse/blob/01a5c25d61f6e23aa4493828c6b7be3e9ff0fad9/css/icon.css#L15

@ghost ghost assigned paulirish Feb 24, 2012
@nimbupani
Copy link
Member Author

How should it be referenced? It is already in the css inlined as a value for html key.

@paulirish
Copy link
Member

I think in the agents object there should be icon properties so if i'm using templating against the JSON i can make use of the imagery.

nimbupani pushed a commit that referenced this issue Feb 29, 2012
@drublic
Use new repo name for CDNed icon, related to #19
55ee692 
Signed-off-by: drublic <[email protected]>
@drublic
Copy link
Member

drublic commented Jun 13, 2012

The icon is here on GitHub and referenced via this repo, right? So this isn't an issue anymore, right?
Would like to close it then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
4 participants
@paulirish @nimbupani @drublic @AaronLayton