Conditional comment for IE6 breaking IE7 + .hide #746
Conversation
|
I'm really :/ on adding the conditional comment thing is BIZARRE and im surprised this is the first time we've heard of it. but it makes me want to distrust IECollection before we change our markup. |
|
Sounds like you're having a problem with IECollection's IE7...it's known to be a bit shaky. If you can reproduce the issue in the official or Spoon version of IE7, then please drop us a testcase to look at. I'm with Paul about |
|
Regarding I am adding this class mostly because of FOUC, ie when i have some element on which i am using jQuery to show/hide it. In that case i need to do one of there:
I'm cool about not adding this to h5bp, but it's just one small helper class and it seems logical to me to add this since it seems there is case for everything(for example To wrap things up, this is something i added in my fork and something that i found it's easiest way for me to stop FOUC from happening. So i am using this and will be using this. If you guys say no for this to go into h5bp - that's cool... :) Regardgin IE7: @necolas if you mean spoon.net IE is not on that site for long time, or i am completely blind and can't find it. :) I'm in the process of installing Windows Vista via virtualbox, so i will test things out and post update here. |
|
You shouldn't be hiding content before JS loads just to avoid a FOUC. It can cause accessibility problems. We don't have any helper classes that are targeting JS-enhanced presentations. Using |
|
@necolas That content needs to be hidden. When you load up the page the content is hidden, you click some button and That is why i was adding that helper class in my projects, so i can just add Regarding conditional comment, i was not able to download Vista from that "microsoft students something something website" which means i didn't test this yet. I am downloading it again and hopefully this time it will work and i will update you guys asap. But anyway, that conditional comment for IE6 is just funny to me, like
Just saying... :) |
|
Right, but just because you want something to be visually hidden in your JS-enhanced presentation doesn't necessarily mean that it should be hidden by default when JS is off, or hidden to screenreaders. |
|
How about |
|
Ok, i tested this conditional comment issue on fresh Vista install and i couldn't reproduce it. Then i tested it again on XP and i couldn't reproduce it there either... So this issue with conditional comment must have been triggered by something else since everything is working now, both on IE7 on Vista and on IE7 on XP via IECollection. Regarding So issue 1 - can't reproduce and issue 2 is a no no -> closing this issue. |
Part 1:
Hello,
conditional comment for IE6 was breaking completely some page i was working on today only in IE7.
Everything i got from a page was styling on html element, nothing else, just like it parsed only html element and then stopped.
This was ran on IE7 on XP SP3(installed on Windows7 via http://www.virtualbox.org/ ) as part of http://utilu.com/IECollection/ install i have on that virtual machine.
So it's fresh install of XP with only IECollection installed(IE6, IE7 and IE8).
IE6 and IE8 worked ok, but this:
<!--[if lt IE 7]> <html class="no-js ie6 oldie" lang="en"> <![endif]-->just wasn't letting IE7 to work. So just as a goof i tried:
<!--[if IE 6]> <html class="no-js ie6 oldie" lang="en"> <![endif]-->After that IE7 worked like a charm.
I really have no idea why is this happening, just wanted to report this to you guys. <3
Part 2:
I really don't know how to create two separate pull requests and i hope it's not a problem if i do it like this? ;(
Anyway, whenever i am using something like .hide(), .show(), .slideToggle() in jQuery those methods are only changing display value of given element. And if i want to hide it initially i don't have any class in h5bp which i can use, so i always add .hide class which handles only display value.
For example, .hidden will apply
visibility: hiddenso after .show() jQuery call the element is still invisible.I added comment for that class based on comments for other hide-a-like classes that are currently in h5bp, please update it if you think it should be any different.