-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parcel renames favicon.ico #2474
Comments
We do have it documented and you interpreted it correctly. Browsers pick up favicon.ico in the root of your site. Something else was going on with your icon.
read this post by @mathiasbynens for full details rel="shortcut icon" considered harmful · Mathias Bynens Also see #2243 |
I would ask you to double check this. I understand that browsers pick it up in the root of the website, however, as I understand it, parcel (built in to h5bp) modifies the file name which means this no longer gets picked up. The file 'mysite/favico.ico' gave me a 404. Having added the above modification, desktop browsers picked up the new favicon, and I can see the file name as I have not modified the parcel configuration at all nor renamed favicon.ico, so I don't think this was a problem on my end. |
I don't need to double check the basic behavior or the way we implement favicons. The commit removing |
Great, I think that would be very helpful. |
I find the cache-busting filenames in Parcel to be quite frustrating too. |
Maybe we should migrate to Vite instead? |
* Proposal: Let's Replace Parcel With Webpack Closes #2487 and #2474 This is just a development server at this point. It hot reloads HTML JS and CSS. That's enough for me. I'm open to contrary opinions. * Updates based on @coliff review * wip * fix merge conflict * removing comment * Final tweaks to docs
Parcel is dead. Long live WebPack, apparently. We do need to make sure that things like this don't happen going forward, so thanks for the report. |
I'm submitting a ...
Notes:
I struggled for a while to understand why my favicon was not showing properly. It turns out I needed to add
<link rel="icon" href="favicon.ico" type="image/x-icon">
toindex.html
but this did not seem obvious to me and the comment<!-- Place favicon.ico in the root directory -->
was not very helpful (in fact, I interpreted it as that I only need to updatefavicon.ico
and not add the above line).The text was updated successfully, but these errors were encountered: