-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default h5bp download to stripped #1048
Comments
Why? IMHO, this would only make the default H5BP download more magical (“Why is this line here? Oh, if I remove it, x and y break! Better not touch it.”) and less educative. |
Must agree with @mathiasbynens there... imo the boilerplate should be understood, not taken for granted as magic. Performance advantages of using some (automated) build process to strip comments, etc are already noted (and linked) in the h5bp documentation.
|
Yes, I agree with Mathias, too. I personally like it when I go through the index.html, looking for stuff I can kick out and can directly use the links provided to go to the docs-page for additional header-info. |
Hey there @paulirish I've setup a really basic gruntfile + html-striping-comment class through html-minifier. Maybe that fits what you're looking for here :) (→ https://gist.github.com/11b15861be04ae8f4a50) A little "quick-and-dirty" but it should work. |
Hans, Mathias, Yes the default would have less docs. Of course. I think the project is old enough that most of the people using it have touched it before.. and learned all the tricks. The docs are still 1) in the doc'd version 2) in the github repo (master) 3) probably in the real documentation .. so they still seem accessible. If you want docs though, you pick the doc'd version. as for why.. It just feels a little old and stuffy.. heavy even to keep them around in the default. H5BP is stable enough that it is actually "boilerplate". Let's drop the superfluous extras and settle on the basis. |
@paulirish you make a good case... many libraries and frameworks ship as a production version by default, with a separate, commented, development version; don't see why H5BP should be deployed otherwise. Can't argue that the documentation for H5BP available online is extremely thorough. :) |
You are right: H5BP has "matured" to a level where people know what it is good for. I use the Ant Build Script to remove all "trash" so I can only speak for people using a build script. As it turns out most of the people using H5BP do not use some kind of build scripting (survey of devs). This leads me to the conclusion that it would be better to use at least some kind of striping for the default version. And as you described, Paul: the un-striped version is still available. In favor of "new is always better", I'd say lets try shipping the striped version by default. If ppl complain about it we could go back to un-striped. |
I still stand by my previous comment.
How would you know? Any data on that? Or is it just a gut feeling? I use h5bp as a starting point whenever I give an “HTML5 workshop”, and for newcomers the comments are highly educative. If stripped became the default I could just point them to the alternative, non-stripped version, sure — but that only complicates things more for people who are new to the project already (and who could use a little help / extra info). Devs who feel they’re familiar enough with the project to get rid of all the comments can just download the stripped version. Everyone else is better off with the commented version, IMHO. |
The project's maturity doesn't necessarily indicate global adoption, so there's definitely a volume of new users to consider. @mathiasbynens, you could say this for a number of frameworks and libraries, I suppose the only difference here is that you're working inside boilerplate source, not building entirely on top of or alongside it. What impact does a default option have here? Is this for the h5bp.com site or are there other single points of entry that would link to either a stripped or un-stripped version of the boilerplate? For example, the options to download as they are now ("Default", "Stripped", "Unstripped") seem fine. What's the current volume of downloads of the two versions. Perhaps the default should just be the most popular of the two? Like @drublic points out, it's difficult to make assumptions around the level of developer downloading the boilerplate, so traditionally you would adjust mainly to accommodate new, unfamiliar users. |
I just added analytics to see who is downloading what. h5bp/html5boilerplate.com@deca4d2...e241f7d we're already tracking the custom builds.. i have a summary of past 30 days of custom builds here: https://docs.google.com/spreadsheet/ccc?key=0ArK1Uipy0SbDdGtmOUZ4QTBYQmpuWHBLUGJEOWNIU0E#gid=0 if anyone wants to summarize that. |
Yeah @paulirish has a point since h5bp is enough popular & is being used very regularly & a stripped would surely help as an alternative for the main package (with all the comments & docs in it) ! |
@paulirish anything conclusive since implementing those analytics? :) |
That is a large % for "default"! May I guess that some of that % is due simply to "default" being the first link? Then you can see how much real demand there is for a commented .zip. |
Idea (might be silly, ignore if it is)
I've seen some requests on h5bp.com/docs comments for making the doc available offline. |
@mklabs Not a bad idea, imo, but just to clarify do you mean the other way round. Stripped version (no comments inline) would come with a separate documentation package (.md files would make sense for this). I think treating the h5bp as more of a framework and pushing out a 'no noise' version makes sense, as long as contextual comments are kept in place. So, displaying sections intended for user interaction (e.g. "css goes here") would not be affected. The documentation is very clear alone. Imagine if jQuery was shipped with inline comments by default? @paulirish anything new regarding the stats, or have those percentages remained pretty much the same? @tomByrer I had the same thought regarding a user's inclination to choose the 'default' option since it says 'default' ...if possible, it would be worth trialling each option as a more exposed call-to-action |
The stats are for the website?! There are three buttons which all look nearly similar. If 70% of downloads are the full package I don't see any reason to change it. In this case "switching to stripped version" would mean to change the files in master only? Including the whole documentation from the wiki requires a build-process for the package I guess. But I like the idea of making the documentation available offline. |
@drublic 70% of downloads are for 'default', which happens to be the full package ...I'm guessing the master would still remain full and you'd have some kind of distribution (dist) directory or branch? Still quite on the fence about this one, myself, but don't see why it's not worth investigating a change thoroughly. :) |
@Aaunel Well, here are the buttons from the website. Which one is the default? (I know it's the left one. But the others look the same, right?) |
@drublic yep, I see what you mean, so the results shouldn't be shifted much, especially given the 'stripped' version sits in the middle... however, what if it said, download... "Boilerplate 'Unstripped'" and "Boilerplate" - would that make a difference? Worth checking the results of a change like this. My other question still stands, too. Are there download links elsewhere, that can only point to one version? |
I was thinking more like this, though perhaps with icons to help clarify & spruce things up: http://d.pr/i/I66O <p class="dwn">
<span><a name="production" href="http://github.com/h5bp/html5-boilerplate/zipball/v3.0.2stripped"><u>Download</u> "production"</a> <small>Stripped clean of comments, just the bizniss.</small></span>
<br><i>or</i><br>
<span><a name="development" href="http://github.com/h5bp/html5-boilerplate/zipball/v3.0.2"><u>Download</u> "Development"</a> <small>Stuffed full of docs, hints, and links</small></span>
<i>or</i>
<span><a href="github" id="builder-custom"><u>Fork at Github</u> "Source"</a> <small>Contribute patches, view in the raw.</small></span>
<i>or</i>
<span><a href="#builder" id="builder-custom"><u>Roll your own</u> "Customizer"</a> <small>100% hipster.</small></span>
</p> Might not need the "Contribute on Github" text link below the "source" link. |
Isn't this more of an issue for the .com repo? Redesigning the site in general is something I hope to kick start at some point. |
@necolas Yes, it seemed to morph in more of a webpage thing. |
updated stats after 5 days and 2400 downloads: documented: 70% jonathan reported he gets 1800 DL's per day on initializr, actually, so |
How many of those DLs at initializr are unique IPs? |
@tomByrer I could be a few of those statistics, got quite excited with the pick & mix prospect :) ... I like the structure above - Production, Development, Custom
@paulirish what do you mean by that? |
@Aaunel Thanks, I stole "Production, Development" from jQuery. I figured there was a good cross over of target markets. |
I'm sure the community wouldn't mind doing a survey? It'd be nice to know how many people use .htaccess and remove the meta tags |
In some sense, we maybe shouldn't even be providing a "stripped" version at all. I'm not a fan of stripping CSS comments and formatting. It should be part of a build step and not the basis for development code. That only leaves us with the comments in The idea of including docs in the main repo is interesting. I've found it to work well for grunt. Benefits:
Drawbacks:
|
+9001 |
⬆️ |
As a repeat user of the H5BP, I get tired of looking at those HTML comments and exhaustive inline CSS documentation. Your first few times with it, you'll look things up and learn new techniques. After a while you trust the platform and go with it. After this point, the comments (and additional whitespace) are in your face and slowing down your development. I want the comments in the source to be unique to my app and communicative about whats going on inside of it, not what's going on in my dependencies. I still think the dev branch should be with comments inside it, but I'm just proposing that return users have an easy way to download stripped. That and I hate perpetuating the reputation that H5BP is large and bulky. :/ |
That's why I keep coming back to H5BP, inline comments. (And why I recommend it to other people) |
Those CSS comments are largely from normalize.css. In your dev code, there should be clear comments. Nothing worse than being introduced to a project/site codebase and there being inadequate comments there and no one who remembers why certain lines of code were included. Given that the base CSS is full of workarounds and browser normalizations, it's important for it to be clear why each line is there (and why you may or may not need it depending on your support matrix)...not just for people working on this project but for other developers who joint teams that use HTML5 Boilerplate as a base for their site.
Part of my drive to split the CSS into separate files is to avoid mixing various presentational layers and parts in a single file. Other than that, I don't really think this is a problem. If you're writing your app's CSS code you shouldn't really be doing that in the same file as normalize.css or print styles. As for the HTML, I'd be in favour of reducing the number of comments there because I don't think many of them add value. Some are stating the obvious or would be better kept in a bundled
Since removing |
Reduce the perceived complexity and verbosity of certain files by stripping unneccessary inline comments. Relevant documentation may end up in a `doc/` directory such that any download has an accurate and matching code documentation bundle. Ref gh-1048
Closing now. Would like to look into avoiding a stripped branch going forward. |
Reduce the perceived complexity and verbosity of certain files by stripping unneccessary inline comments. Relevant documentation may end up in a `doc/` directory such that any download has an accurate and matching code documentation bundle. Ref h5bp/html5-boilerplate#1048
I think we're at a point now where we could change the default download to stripped, and provide an optional package that is h5bp-documented with all the comments.
Thoughts?
Side wish, I wish there was an easy shell/node script I could use to stripped-ify the git repo.
The text was updated successfully, but these errors were encountered: