Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Sensors, particularly power and energy sensors to work with statistics. And patch climate controls #44

Closed
wants to merge 14 commits into from

Conversation

robigan
Copy link
Contributor

@robigan robigan commented Mar 12, 2022

No description provided.

@kubaceg
Copy link

kubaceg commented Jun 23, 2022

What's the status? Can I help develop/test it?

@robigan
Copy link
Contributor Author

robigan commented Jun 28, 2022

What's the status? Can I help develop/test it?

Dead, summer holidays started for me, so I may get back to patching and improving. I also want to see how different the new by web servers differ from the ones this repo support, but I don't own any hardware to test, so...

@robigan
Copy link
Contributor Author

robigan commented Jun 28, 2022

@h4de5 Can u verify this pr?

@h4de5
Copy link
Owner

h4de5 commented Jun 28, 2022

@robigan I am aware of it - there is a working branch with many more changes here: https://github.com/h4de5/home-assistant-vimar/tree/room_integrations

i need to check first if this would conflict.

@robigan
Copy link
Contributor Author

robigan commented Jun 28, 2022

@robigan I am aware of it - there is a working branch with many more changes here: https://github.com/h4de5/home-assistant-vimar/tree/room_integrations

i need to check first if this would conflict.

Just tried merging this PR into rooms_integrations, should be all smooth apart from the 3 conflicting files. For .gitingore you can implement my change (current change), for climate.py, implement the incoming change but do set the function mode to VIMAR_CLIMATE_MANUAL because otherwise you won't be able to set temp in auto mode. And manifest.json is to just bump the version

@robigan
Copy link
Contributor Author

robigan commented Jun 28, 2022

Opened a new PR if you just want to quickly merge with what I said

@h4de5
Copy link
Owner

h4de5 commented Jul 24, 2022

after checking again, this is already included in #48

@h4de5 h4de5 closed this Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants