Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration is using deprecated DEVICE_CLASS_* constants #54

Closed
frenck opened this issue Jan 3, 2023 · 2 comments
Closed

Integration is using deprecated DEVICE_CLASS_* constants #54

frenck opened this issue Jan 3, 2023 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@frenck
Copy link

frenck commented Jan 3, 2023

Describe the problem

This custom integration uses deprecated DEVICE_CLASS_* constants in its codebase.

The DEVICE_CLASS_* constants have been deprecated and replaced in Home Assistant Core 2021.12 (over a year ago). I would highly suggest updating/migrating this integration to the new enums.

For example, for the device classes supported by the sensor platform, there is now a SensorDeviceClass enum. So if a sensor previously used the DEVICE_CLASS_ENERGY constant, it should now use SensorDeviceClass.ENERGY. Other platforms (like binary_sensor, and number) provide similar enumerations for their supported device classes.

The migration thus only consists of replacing constants with an enumeration member and is, therefore, very low impact and should be fairly straightforward.

If I can help resolve any questions regarding this change or migration, feel free to ask or respond to this issue. I'm happy to help!

Kindest regards,

../Frenck

@frenck frenck added the help wanted Extra attention is needed label Jan 3, 2023
@h4de5 h4de5 closed this as completed in 0338d71 Jan 11, 2023
h4de5 added a commit that referenced this issue Jan 11, 2023
h4de5 added a commit that referenced this issue Jan 12, 2023
h4de5 added a commit that referenced this issue Jan 12, 2023
@h4de5
Copy link
Owner

h4de5 commented Jan 12, 2023

@frenck thank you for reminding

@frenck
Copy link
Author

frenck commented Jan 12, 2023

Awesome for processing it, thanks @h4de5!

../Frenck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants