Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give more visibility when creating release #76

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tetienne
Copy link
Contributor

@tetienne tetienne commented Jul 19, 2022

In order to give more visibility on the modifications and ease the release workflow, I suggest to use release drafter. You can see an example here.

This actions draft the next release notes as pull requests are merged into main branch. So when you want to release a new version, you just have to publish the draft release.

@h4de5 WDYT to add me as contributor on this repository? I would like to maintain it actively.

@h4de5
Copy link
Owner

h4de5 commented Jul 19, 2022

thank you again for your contribution. sorry that I cannot invest more time into reviewing it.

so far I think this is about how the release is shown in the github releases? something like building up the descriptions from the commits since the last release right?

there are three points I don't understand or that I am unsure if this will continue to work:

  1. I know its better to have PRs and seperate branches for each feature - but would this change prevent me from creating a new release by editing code directly in the main branch through the github website?
  2. As you removed the release.yaml - I can't see where the actual release is done. currently there is a condition tied on that manifest version. so a release is only created once that version changes. that way I can make multiple commits into main without creating a new release everytime.
  3. And I would like to keep that minimal release zip file - that one that just includes the custom_component without any of the files in the root directory. I understand this is gone?

@h4de5
Copy link
Owner

h4de5 commented Jul 19, 2022

in regards to your contributor request: I really welcome your changes and the quality you provide with them. I also agree that I do not have enough time on hand to review bugs or PRs, as I am also working on another HA integration here on github and some more oss projects.
the problem I see is, that I do use those integrations by myself. this means any changes done here, are coming to my home sooner or later. and in the past, there has not been a single PR from any contributer that did not break something at home (even though it was tested and it should not break anything). that in turn creates even more work of course - work that I cannot postbone. thats also why I am really cautious with that stupid firmware update from toshiba. I have build up a test environment to test for new PRs but this alone is sometimes too time consuming. e.g. there is an open PR for the vimar integration I am "working" for months now.

Long story short: lets finish this firmware upate and maybe get the release process straight and I will add you as contributor here afterwards.
Thank you very much again for your work!

@chrisandsally
Copy link

I just want to say a massive thank you to everyone that has come together to fix the change Toshiba made, I wish I knew how to code, but a real sincere thanks for personal time that you folks put in for others.

@tetienne tetienne force-pushed the ci/release-drafter branch from 73471f8 to fd6535b Compare July 19, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants