-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Consolidate attribute get code into NimBLERemoteGattUtils #293
base: master
Are you sure you want to change the base?
Conversation
Basically includes the 3 refactors with slight changes to make the generic call work. |
I need some time to test/review this further but it looks great so far. |
I think we should move this outside of |
I originally had the code like this, and had the template function in Would that work? Can you can suggest a suitable name? |
Instead of inheriting I think we should just add it to a header file |
The P4 build errors are not caused by this PR, upstream issue. Please add
|
eb996a3
to
ca0565b
Compare
No description provided.