Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks in case NIMBLE_CPP_DEBUG_ASSERT is not defined. #280

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Add checks in case NIMBLE_CPP_DEBUG_ASSERT is not defined. #280

merged 1 commit into from
Jan 4, 2025

Conversation

thekurtovic
Copy link
Collaborator

No description provided.

@thekurtovic
Copy link
Collaborator Author

I haven't personally experienced any issues in these spots, but I noticed they were only checked by the assert macro which is disabled by default.
Could just modify the macro itself instead, might be cleaner if including NimBLELog into nimconfig.h is acceptable.

h2zero
h2zero reviewed Jan 3, 2025
View reviewed changes
Copy link
Owner

@h2zero h2zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of comments.

src/NimBLEAttValue.cpp Outdated Show resolved Hide resolved
src/NimBLEDevice.cpp Outdated Show resolved Hide resolved
@thekurtovic thekurtovic requested a review from h2zero January 3, 2025 23:58
h2zero
h2zero requested changes Jan 4, 2025
View reviewed changes
Copy link
Owner

@h2zero h2zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of things to tweak.

src/NimBLEDevice.cpp Outdated Show resolved Hide resolved
src/NimBLEAttValue.h Outdated Show resolved Hide resolved
@h2zero h2zero self-requested a review January 4, 2025 22:18
h2zero
h2zero approved these changes Jan 4, 2025
View reviewed changes
Copy link
Owner

@h2zero h2zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@h2zero h2zero merged commit 15cb6bc into h2zero:master Jan 4, 2025
59 checks passed
@thekurtovic thekurtovic deleted the fix-nullptr-check branch January 4, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h2zero h2zero h2zero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekurtovic @h2zero