-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some file types from the Go version #41
base: master
Are you sure you want to change the base?
Conversation
Hey, @h2non what we need to do to merge this PR? Maybe I can help 🙂 |
all doc, xls and ppt are have the same file signature, so no matter which one checked will always detected as a :edit: so here i am confused about how to implement this for ms office document types. :update: |
@@ -134,6 +148,13 @@ Font | |||
- **ttf** - ``application/font-sfnt`` | |||
- **otf** - ``application/font-sfnt`` | |||
|
|||
Document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Group microsoft office pre 2007 documents as application/x-ole-storage
as this 3 types have same file signatures. We can determine the file type by filename extension.
|
||
# Supported application types | ||
DOCUMENT = ( | ||
document.Doc(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc type it will valid for xls and ppt because of same file signature, so no need to define the others.
Added some low hanging fruit file types from the Go version. Put Dcm under archive (as on the Go side). Didn't improve matroska detection or add docx, xlsx or pptx. Nice lib ^^.