Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the dimension_separator param when creating fixtures #154

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Pass the dimension_separator param when creating fixtures #154

merged 1 commit into from
Jun 7, 2024

Conversation

shlomnissan
Copy link
Contributor

@shlomnissan shlomnissan commented Jun 6, 2024 •
edited
Loading

Pass the dimension_separator parameter to zarr.open when creating a fixture for
nested storage. This directly addresses an existing TODO.

@shlomnissan shlomnissan changed the title Pass dimension_separator param when creating fixtures Pass the dimension_separator param when creating fixtures Jun 6, 2024
gzuidhof
gzuidhof approved these changes Jun 7, 2024
View reviewed changes
Copy link
Owner

@gzuidhof gzuidhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you

@gzuidhof gzuidhof merged commit fb95230 into gzuidhof:master Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzuidhof gzuidhof gzuidhof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shlomnissan @gzuidhof