Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaked 的情况还是很多 #296

Open
WTree opened this issue Apr 2, 2022 · 3 comments
Open

Leaked 的情况还是很多 #296

WTree opened this issue Apr 2, 2022 · 3 comments

Comments

@WTree
Copy link

WTree commented Apr 2, 2022

引用 这个库，Leaked 的情况还是很多，建议把dialog 的那个构造传activity 改造下，里面的callback 也考虑用下弱引用持有处理下
@liyujiang-gzu
Copy link
Member

引用 这个库，Leaked 的情况还是很多，建议把dialog 的那个构造传activity 改造下，里面的callback 也考虑用下弱引用持有处理下

这是Dialog的通病，所以谷歌才出了DialogFragment，dismiss的时候注意Activity是否已被销毁

@liyujiang-gzu
Copy link
Member

#294 后续将BaseDialog迁移到DialogFragment

@WTree
Copy link
Author

WTree commented Apr 8, 2022

DialogFragment 也会存在Leak 需要对这个进行稍微调整下，就好了

liyujiang-gzu added a commit that referenced this issue Nov 3, 2022
@liyujiang-gzu
#294 #296
f5751c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WTree @liyujiang-gzu