Skip to content

Commit

Permalink
tpl: Do not return errors in substr for out-of-bounds cases
Browse files Browse the repository at this point in the history
Most other substr implementations don't error out in out-of-bounds cases
but simply return an empty string (or a value that's printed as an empty
string). We'll follow their lead and not exit template execution.  Allow
the user decide what to do with the empty result.

Fixes gohugoio#8113
  • Loading branch information
moorereason authored and gzagatti committed Jan 11, 2021
1 parent 031d04a commit fd8f43c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tpl/strings/strings_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -451,9 +451,9 @@ func TestSubstr(t *testing.T) {
{"abcdef", -3, 1, "d"},
{"abcdef", 0, -1, "abcde"},
{"abcdef", 2, -1, "cde"},
{"abcdef", 4, -4, false},
{"abcdef", 7, 1, false},
{"abcdef", 6, nil, false},
{"abcdef", 4, -4, ""},
{"abcdef", 7, 1, ""},
{"abcdef", 6, nil, ""},
{"abcdef", 1, 100, "bcdef"},
{"abcdef", -100, 3, "abc"},
{"abcdef", -3, -1, "de"},
Expand Down

0 comments on commit fd8f43c

Please sign in to comment.