-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Missing Extended Features #181
Conversation
mert-kurttutan
commented
Jul 15, 2024
•
edited
Loading
edited
- Missing Extended features are those located at edx register and for leaf eax=7,ecx=0
- Implemented new struct for features at edx register to contain those features.
- Changed the display code by adding new features implemented.
- Missing Extended features are those lcoated at edx register and for leaf eax=7,ecx=0
Also, removed unix conditional dependency on phf for testing since it also works on windows. |
I am planning to add extended features for subleaf ecx=1 once we are done with this.
I am planning to not use ebx1 and ecx1. So, this means I should implement bitflag struct for eax1 and edx1, right?
|
Documentation ref (for explanation of bits and definition):
Cross-referenced them to make sure they agree with each other. |
I left some of the bit fields unimplemented since I wont be using them. |
looks good to me, thanks! |
Co-authored-by: Gerd Zellweger <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 42.34% 42.27% -0.08%
==========================================
Files 4 4
Lines 3809 3811 +2
==========================================
- Hits 1613 1611 -2
- Misses 2196 2200 +4 ☔ View full report in Codecov by Sentry. |
- AVX512-vp2intersect bit and method - AMX_TILE and AMX_INT8 method (bits were already implemented) Add new test assertion for the new bits
Thanks a lot for the PR! |
released as 11.1 |