Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade goreleaser version, and enable keyless verification of goreleaser checksums.txt file #67

Closed
wants to merge 0 commits into from

Conversation

developer-guy
Copy link
Collaborator

Signed-off-by: Batuhan Apaydın [email protected]

GoReleaser has just been enabled in keyless signing mode, so, this PR will also enable this support in golang-cross for verifying GoReleaser checksum.txt file. Also, upgrades GoReleaser version to v1.2.2.

cc: @cpanato

Dockerfile Outdated
--signature https://github.com/goreleaser/goreleaser/releases/download/v$GORELEASER_VERSION/checksums.txt.sig \
--cert https://github.com/goreleaser/goreleaser/releases/download/v$GORELEASER_VERSION/checksums.txt.pem \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cert does not accept an URL

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, let's add this support to cosign 🤩

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato let's wait for that before merging this, WDYT?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y'all are so fast 😂

@developer-guy developer-guy changed the title feat: upgrade goreleaser version, and enable keyless feat: upgrade goreleaser version, and enable keyless verification of goreleaser checksums.txt file Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants