Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support authorization code flow in balloon v3 #240

Open
raffis opened this issue Feb 18, 2020 · 1 comment
Open

Support authorization code flow in balloon v3 #240

raffis opened this issue Feb 18, 2020 · 1 comment
Labels
auth change
Milestone
2.0.x

Comments

@raffis
Copy link
Contributor

raffis commented Feb 18, 2020 •
edited
Loading

Describe the change

The balloon server v3 ships an idp with authorization code flow only.
See gyselroth/balloon#435

Current situation

Currently the desktop client supports:

  • resource owner password grant
  • external idp's
  • basic auth
  • two factor auth (using a custom resource owner password flow)

Should

Support in v2 will get removed for all of those methods and only the internal balloon idp will be supported. Any 3rd party auth methods can be configured on the balloon auth service in v3.

Additional context

See auth server: https://github.com/gyselroth/balloon-auth-consent
@raffis raffis added this to the 2.0.x milestone Feb 18, 2020
raffis added a commit that referenced this issue Feb 18, 2020
@raffis
support authorization code only and the internal balloon idp
77665f6 
wip #240 and #241
raffis added a commit that referenced this issue Feb 18, 2020
@raffis
removed secret type per instance since the choosen one is always
dc7bffb 
accessToken

wip #240
raffis added a commit that referenced this issue Feb 18, 2020
@raffis
removed orphaned css
a751323 
wip #240
raffis added a commit that referenced this issue Feb 18, 2020
@raffis
removed debug logging #240
09f2137
@pixtron
Copy link
Member

pixtron commented Mar 2, 2020

Also remove deprecated identifying instances by username (see #230). The deprecated changes are marked with // TODO pixtron - deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auth change
Projects
None yet
Milestone
2.0.x
Development

No branches or pull requests
2 participants
@pixtron @raffis