Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tray behaviour for linux #207

Open
pixtron opened this issue Nov 14, 2019 · 2 comments
Open

New tray behaviour for linux #207

pixtron opened this issue Nov 14, 2019 · 2 comments
Labels
change hasfix linux user-interface
Milestone
1.3.x

Comments

@pixtron
Copy link
Member

pixtron commented Nov 14, 2019 •
edited
Loading

Describe the change

As electron/electron#14941 is still not fixed, the idea on linux is, to just have a context menu "Open Balloon", "Close Balloon", "Feedback", ...

Click on "Open Balloon" will open the current Tray Window.

Related to #132

Also update electron-traywindow-positioner to v1.1.x
@pixtron pixtron added the change label Nov 14, 2019
@pixtron pixtron added this to the 1.3.x milestone Nov 14, 2019
@raffis
Copy link
Contributor

raffis commented Jan 21, 2020

Note: electron v8 electron/electron#21445 tray icon is not displayed on my linux mint 19 cinnamon

@pixtron
Copy link
Member Author

pixtron commented Jan 21, 2020

Probably we need to scale the tray icon correctly as mentioned here: electron/electron#21445 (comment)

pixtron added a commit that referenced this issue Feb 13, 2020
@pixtron
New tray behaviour for linux
b3469cd 
Resolves: #207
pixtron added a commit that referenced this issue Feb 13, 2020
@pixtron
New tray behaviour for linux
a1c72b5 
Resolves: #207
@pixtron pixtron added the hasfix label Feb 13, 2020
pixtron added a commit that referenced this issue Feb 17, 2020
@pixtron
Fix TypeError: Cannot read property 'setContextMenu' of undefined
84b6bbe 
Fixes regression introduced with a1c72b5
Related to: #207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change hasfix linux user-interface
Projects
None yet
Milestone
1.3.x
Development

No branches or pull requests
2 participants
@pixtron @raffis