Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default dev mode server to static implementation #10057

Open
niloc132 opened this issue Dec 12, 2024 · 1 comment · May be fixed by #10103
Open

Change default dev mode server to static implementation #10057

niloc132 opened this issue Dec 12, 2024 · 1 comment · May be fixed by #10103
Milestone
2.13

Comments

@niloc132
Copy link
Member

niloc132 commented Dec 12, 2024 •
edited
Loading

Starting in GWT 2.11 (see #9863 and #9866) a new dev mode server implementation was introduced - com.google.gwt.dev.shell.StaticResourceServer. At the same time, the JettyLauncher implementation was deprecated, and logs a warning to the console when used.

This ticket proposes that in GWT 2.13 the default be changed to StaticResourceServer, with the JettyLauncher left for at least one more version before being removed.

As an alternative, we could remove the default server entirely and change to -noserver by default, so that any user specifying -server needs to also pick the server implementation they want to use.
This was referenced Dec 12, 2024
Open
Open
@eliasbalasis
Copy link

eliasbalasis commented Dec 12, 2024 •
edited
Loading

I can see JettyLauncher etc. disappearing eventually, primarily in favor of external server wiring but also in relation to maintenance headaches and related struggles.

@niloc132 niloc132 added this to the 2.13 milestone Dec 19, 2024
@jnehlmeier jnehlmeier mentioned this issue Dec 23, 2024
Closed
@niloc132 niloc132 mentioned this issue Feb 9, 2025
Open
niloc132 added a commit to niloc132/gwt that referenced this issue Feb 26, 2025
@niloc132
Change default SCL instance, and allow selecting from service loader
6a6ae68 
The default is now to ask a service loader for a
ServletContainerLauncher if there is a single entry available, and
failing that to use the static server - no servlets will be available.

ServletContainerLaunchers registered as a provider for the service
loader must provide a name that matches a specific regex. Those names
may now also be used when specifying a particular server name rather
than the fully qualified class name.

The JettyLauncher will be kept for at least another version to ensure
that projects can easily migrate to newer versions.

Fixes gwtproject#10057
niloc132 added a commit to niloc132/gwt that referenced this issue Feb 26, 2025
@niloc132
Change default SCL instance, and allow selecting from service loader
f5ffb5e 
The default is now to ask a service loader for a
ServletContainerLauncher if there is a single entry available, and
failing that to use the static server - no servlets will be available.

ServletContainerLaunchers registered as a provider for the service
loader must provide a name that matches a specific regex. Those names
may now also be used when specifying a particular server name rather
than the fully qualified class name.

The JettyLauncher will be kept for at least another version to ensure
that projects can easily migrate to newer versions.

This patch also moves `setBaseRequestLogLevel` to
ServletContainerLauncher so other implementations can use it to log
appropriately based on how they were started.

Fixes gwtproject#10057
@niloc132 niloc132 linked a pull request Feb 27, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13
Development

Successfully merging a pull request may close this issue.

Change default SCL instance, and allow selecting from service loader niloc132/gwt
2 participants
@niloc132 @eliasbalasis