Update instructions since pip has removed the --process-dependency-links option #1201
Conversation
|
I don't know what dependency links are. What should this option take in? What would the error message be without it? |
|
@samantha-usman ok, this is more complicated that I thought. https://github.com/ligo-cbc/pycbc/blob/master/setup.py#L73 However, it appears that the pip maintainers have removed this feature in pip 9.0 (see pypa/pip#1519 and pypa/pip#3939). The solution to this is to add a line to the instructions telling the user to install mpld3, like we do for the segment database tools. I will update with that patch in a few minutes. |
|
@samantha-usman I have updated the instructions to tell you do a an explicit install of mpld3: as part of the installation of required packages. I removed the deprecated @ahnitz I also removed it from the @samantha-usman please try this and see if it works. Please comment here if it works or fails, or if you are having issues with the instructions. |
duncan-brown
changed the title
| @@ -70,7 +70,6 @@ | |||
| 'corner>=2.0.1', | |||
| #'scikit-learn>=0.17.0', # travis does not like scikit-learn | |||
| ] | |||
There was a problem hiding this comment.
do not remove from the setup.py. It is required afterall. Even if you are installing from outside pycbc, we should not remove the dependency.
There was a problem hiding this comment.
But that directive has been deprecated in both setuptools and pip. We shouldn't have it there if it's a broken noop. If you want it in setup.py, the right thing to do is release a pycbc-mpld3 in PyPi and then add it to the regular requirements.
duncan-brown
dismissed
ahnitz’s stale review
mpld3>=0.3git is still listed as a requirement so the user must have manually installed it
|
@duncan-brown I think this is the better solution. I |
|
I incorporated #1204 here so that it also gets the other fixes to the documentation. |
…nks option (gwastro#1201) * Tell pip to bring in all the dependencies * Fixed typo that hid instructions to update pip * Point to new DASWG repository page * removed link as process dependency links has been removed from pip * fix instructions to remove process-dependency-links * removed deprecated dependency_links * get mpld3 from pypi
Add the
--process-dependency-linksoption to pip to bring in the dependencies that PyCBC needs.