-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow VLA serialization with t=254 #28
Conversation
I can add your proposed pcall solution for issue #25 if you wish. |
Type IDs are going to conflict very soon :(
Should some "extended type ID marker" be assigned soon? As in, if 254/255, the next byte is a new type id. effectively giving 255 more free IDs
|
I would like to see if I can fold VLAs and VLSs into type code 252 first. @adriweb Yes, in my head I'd already reserved type code 255 for some kind of "extended type" thing. I'm not sure what the semantics of it are going to be yet. |
So, what is going to be done' |
Another way to distinguish VLA and VLS is that |
Apologies, I haven't looked at bitser for the past 3 1/2 year. Right now I can't promise anything, but I hope I can find the time to get reacquainted with bitser, luajit and your proposed fixes in January. |
meanwhile I have implemented another option in https://github.com/sonoro1234/anima/blob/master/anima/cdataser.lua |
That is probably the way to go. I'm currently attempting to fix serialization of I'm tempted to declare all
Even without cdata etc, bitser is not endian-safe, I should probably add something about that in the README. |
This PR is no longer applicable since c95cb0d. |
This solves issue #27