Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of TextTemplateBuilder #99

Closed
gvlasov opened this issue Aug 16, 2015 · 1 comment
Closed

Get rid of TextTemplateBuilder #99

gvlasov opened this issue Aug 16, 2015 · 1 comment
Assignees
@gvlasov
Labels
design
Milestone
0.1.0

Comments

@gvlasov
Copy link
Owner

gvlasov commented Aug 16, 2015

TextTemplateBuilder was introduced because the content of TextTemplate's body was considered heterogeneous. It was a list of either Placeholders or plain text, and I thought it is not worth it to unify those under a single interface (see #74).

Now I see that it is possible to unify placeholders and plain text with addition of one more layer. The template body will consist of TemplateBodyPieces with method #fillOut(ActualArguments, Vocabulary). Those TemplateBodyPieces will encapsulate either a placeholder or plain text.
@gvlasov gvlasov added the design label Aug 16, 2015
@gvlasov gvlasov self-assigned this Aug 16, 2015
@gvlasov gvlasov added this to the 0.1.0 milestone Aug 16, 2015
@gvlasov
Copy link
Owner Author

gvlasov commented Aug 17, 2015

Must be done after #96

gvlasov pushed a commit that referenced this issue Aug 20, 2015
#99 Extract BasicTemplate inner class from TextTemplateBuilder
7fe28b9
gvlasov pushed a commit that referenced this issue Aug 20, 2015
#99 Remove TextTemplateBuilder
1628bdb
gvlasov pushed a commit that referenced this issue Aug 20, 2015
#99 Use the new TemplateBodyPiece interface in ParsedTemplate
728a49e
gvlasov pushed a commit that referenced this issue Aug 20, 2015
#99 Remove usages of TextTemplateBuilder
4884704 
Also removed usages of other classes (and tests for them) that are no longer needed
@gvlasov gvlasov mentioned this issue Aug 20, 2015
Merged
gvlasov pushed a commit that referenced this issue Aug 20, 2015
#99 Remove an unused constructor
21360a6
@gvlasov gvlasov mentioned this issue Aug 20, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvlasov gvlasov

Labels
design
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
1 participant
@gvlasov