Add 'findutils' to Fedora-based Docker images #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'find' command was not installed in our minimal Fedora 26 and 27-based Docker images. This resulted in a non-fatal error when performing a 'make clean'. This commit adds this utility (available in the 'findutils' package). Signed-off-by: Geoffroy Van Cutsem <[email protected]>
gvancuts
pushed a commit
that referenced
this pull request
Aug 20, 2020
OpRegion: 8KB(0x2000) [ OpRegion Header ] Offset: 0x0 [ Mailbox #1: ACPI ] Offset: 0x100 [ Mailbox #2: SWSCI ] Offset: 0x200 [ Mailbox #3: ASLE ] Offset: 0x300 [ Mailbox #4: VBT ] Offset: 0x400 [ Mailbox #5: ASLE EXT ] Offset: 0x1C00 Extended OpRegion: 8KB(0x2000) [ Raw VBT ] Offset: 0x0 Generally VBT stores in MailBox4 in OpRegion which max size is 6KB. If VBT larger than 6KB, it will be stored in extended OpRegion which is neighborhood with legacy OpRegion. In this case, we need to passthrough extended OpRegion also to support GVT-d feature. The OpRegion size that we passthrough should be (OpRegion+Extended)=16KB ASLE.rvda stores the location of VBT. For OpRegion 2.1+: ASLE.rvda = offset to OpRegion base address For OpRegion 2.0: ASLE.rvda = physical address To-do: Add support for OpRegion on some platforms(eg. APL) Tracked-On: projectacrn#5029 Signed-off-by: Sun Peng <[email protected]>
gvancuts
pushed a commit
that referenced
this pull request
Mar 10, 2022
'mevent_lmutex' is initialized as default type, while attempting to recursively lock on this kind of mutext results in undefined behaviour. Recursively lock on 'mevent_lmutex' can be detected in mevent thread when user tries to trigger system reset from user VM, in this case, user VM reboot hang. The backtrace for this issue: #1 in mevent_qlock () at core/mevent.c:93 #2 in mevent_delete_even at core/mevent.c:357 ===>Recursively LOCK #3 in mevent_delete_close at core/mevent.c:387 #4 in acrn_timer_deinit at core/timer.c:106 #5 in virtio_reset_dev at hw/pci/virtio/virtio.c:171 #6 in virtio_console_reset at hw/pci/virtio/virtio_console.c:196 #7 in virtio_console_destroy at hw/pci/virtio/virtio_console.c:1015 #8 in virtio_console_teardown_backend at hw/pci/virtio/virtio_console.c:1042 projectacrn#9 in mevent_drain_del_list () at core/mevent.c:348 ===> 1st LOCK projectacrn#10 in mevent_dispatch () at core/mevent.c:472 projectacrn#11 in main at core/main.c:1110 So the root cause is: mevent_mutex lock is recursively locked by mevent thread itself (projectacrn#9 for this first lock and #2 for recursively lock), which is not allowed for mutex with default attribute. This patch changes the mutex type of 'mevent_lmutex' from default to "PTHREAD_MUTEX_RECURSIVE", because recrusively lock shall be allowed as user of mevent may call mevent functions (where mutex lock maybe required) in teardown callbacks. Tracked-On: projectacrn#7133 Signed-off-by: Yonghua Huang <[email protected]> Acked-by: Yu Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'find' command was not installed in our minimal Fedora 26
and 27-based Docker images. This resulted in a non-fatal error
when performing a 'make clean'. This commit adds this utility
(available in the 'findutils' package).
Signed-off-by: Geoffroy Van Cutsem [email protected]