Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to reflect Storybook 6 changes #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tarikhamilton
Copy link

addDecorator and storiesOf are both deprecated, but this still seems to work fine with Storybook 6. Updated to reflect changes in their API.

https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md#600-beta42-july-5-2020
https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md#600-beta37-june-26-2020

@tarikhamilton
Copy link
Author

Whoa, I really jumped the gun on this and assumed that an error going away meant I fixed my Storybook React router issue, but there seems to be more work to do.

@tarikhamilton
Copy link
Author

I was using the default export, which just passes stuff through the same props, so should have the same results as the previous working incarnation.

@tarikhamilton tarikhamilton reopened this Dec 28, 2020
@tarikhamilton tarikhamilton marked this pull request as draft December 28, 2020 19:31
@tarikhamilton tarikhamilton marked this pull request as ready for review December 31, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant