Feature Request: Display all items if query is empty

[taybin]

When the query is empty, I'd like to display the full set of items.

[guylabs]

Hi Taybin,

you need to implement the proper itemsMethod which returns all items when the passed in query is empty. You can read more about the itemsMethod here: https://github.com/guylabs/ion-autocomplete#the-items-method.

Or do you mean that the component does a call to the itemsMethod with the empty query when the dialog opens such that you already have a list before entering something? This way you also need to implement what I wrote in the first paragraph, but the behavior is different when the dialog opens.

Please let me know what exactly you mean.

Thanks and regards,

Guy

[taybin]

I have a working itemsMethod function.

According to this (https://github.com/guylabs/ion-autocomplete/blob/master/src/ion-autocomplete.js#L172), it short-circuits the searchQuery $watch handler if the query is empty. I don't see any way to get the component to call the itemsMethod handler with an empty query.

[joelbrewer]

I am also trying to accomplish this. Is it currently possible?

[guylabs]

I tried to change the behavior but there are some failing tests which I need to fix. I hope I can finish it till the weekend.

[joelbrewer]

@guylabs fantastic!

[guylabs]

Hi you two,

I just added the functionality to the master. Could you please check it if it works and then write me such that I can close the issue?

Thanks and regards,

Guy

[joelbrewer]

This is really close.. Only problem is when I first open the dialog the formatting is off:

[joelbrewer]

Also, it would be nice if that list remained populated after clicking on an item. But maybe that's already a feature?

[taybin]

I had the formatting problem too. I fixed it locally by breaking out the function $watch('searchQuery') calls into its own named function and then calling that at the bottom of the onclick handler.

[guylabs]

Ok I just fixed this issue too with the workaround that @taybin mentioned. Thanks for that!

@JahBrewski What do you mean that this list remains populated? That the list is never cleared if the query is an empty string? You mean to remove this part here right: https://github.com/guylabs/ion-autocomplete/blob/master/src/ion-autocomplete.js#L167 ?

[TimoSolo]

Wonderful! I was just looking for this and saw you already updated the code :)
Works well. One little issue is that it calls the method twice (once when it loads the page and again when you click on the autocomplete field)

[guylabs]

Hi Timothy,

well the problem is that Angular calls the &watch method at the beginning and with this change now to allow empty values it's not possible to just call the method when the real search input field is used. If anyone has an idea how to solve this then please tell me such that I can fix it or create a pull request.

Now for this issue: @taybin @JahBrewski I closed the issue now as @TimoSolo tested it but if there is an issue just reopen it.

Thanks and regards,

Guy

[guylabs]

Hi,

I just found out a way to not call the items-method for nothing: 5f9c56b. This also fixes some other places where the items-method was called because I set the searchQuery to an empty string.

Now the items-method is just called if the component needs the data. This also improves the performance such that it doesn't make useless calls to the back end.

Regards,

Guy

[TimoSolo]

Hmm.. that seems to break the initial list though.

I've got the code to work the way I want it: when you click on the ion-search it shows the full list. also when you select something it saves the search.

Created pull request: #42

[TimoSolo]

This still isn't working for me with the updates - it only shows the list if you start typing.. what do you think of the suggested pull request?