Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ionic 1.3 #189

Closed
engkordi opened this issue Jul 3, 2016 · 6 comments
Closed

Support Ionic 1.3 #189

engkordi opened this issue Jul 3, 2016 · 6 comments
Assignees
Milestone

Comments

@engkordi
Copy link

engkordi commented Jul 3, 2016

Did you have plan to support ionic 1.3 ?

@metalaureate
Copy link

metalaureate commented Jul 3, 2016

As far as I can tell (not an expert) it works for Ionic 1.3 except for isInitializing which is never set.

@engkordi
Copy link
Author

engkordi commented Jul 5, 2016

I tried this but without any hope, the issue with "items-method" directive.

@guylabs guylabs added this to the 0.3.4 milestone Aug 13, 2016
@guylabs guylabs self-assigned this Aug 13, 2016
@guylabs
Copy link
Owner

guylabs commented Aug 13, 2016

Hi

sorry for my delay but I was on a longer trip and now I am working partially.

Yes I will try to support it in version 0.4.0. I will first release the 0.3.3 and then go ahead with that one.

Could @metalaureate and @engkordi maybe provide more information about the issues they had and maybe how they worked around it/fixed it?

Thanks and regards,

Guy

@djehring
Copy link

I have encountered another issue with using 1.3. The searchInput is rendered behind the $ionicBackdrop so is unresponsive. Adding z-index:12 to the template style fixes the issue

@guylabs
Copy link
Owner

guylabs commented Sep 18, 2016

@djehring Thanks for pointing this out! I will try to work on it asap, but currently I am still abroad and do not know when I got the time again.

guylabs pushed a commit that referenced this issue Feb 23, 2017
- update some package dependencies too
@guylabs
Copy link
Owner

guylabs commented Feb 23, 2017

Hi

I finally got some time and this is now fixed on master and will be released in 1.4.0. In the latest 1.3.2 version I did not encounter these issues.

Could you maybe test it if you have the time. I will then release 1.4.0 anyway as there are other issues pending.

Regards,

Guy

@guylabs guylabs closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants