-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mambaforge installer #22
Conversation
@@ -0,0 +1,2 @@ | |||
* | |||
!start_azure.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a .dockerignore
isn't strictly necessary to add support for mamba, but I think it's generally a good idea and thought now was a good time, given that we're about to test this new image anyway.
For details on this file, you can see https://codefresh.io/docker-tutorial/not-ignore-dockerignore-2/.
Benefits:
- smaller build context = faster builds
- reduced risk of accidentally including unnecessary files
- smaller images
- less risk of including secret / sensitive information
Done! |
Thank you very much! I just updated this to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Agree with your plan. Please consider checking my suggestion about paths and filenames renaming below.
dockers/ubuntu-14.04/Dockerfile
Outdated
@@ -84,11 +84,10 @@ RUN curl -sLk https://sourceforge.net/projects/swig/files/swig/swig-4.0.2/swig-4 | |||
&& rm -rf swig-4.0.2 | |||
|
|||
# Install Miniconda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't make a suggestion for all these lines, so describing my suggestion just in words.
Let's be explicit here and don't call Mambaforge installation as "Miniconda"/"conda".
Please update lines 86-95 making it clear we are working with mamba[forge]
. The only public entrypoint here is CONDA
env variable, so don't change its name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, works for me!
updated in f75b7a4 and tested that building the image still works
Co-authored-by: Nikita Titov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you @jameslamb , I will give you the write permission. |
thanks very much @guolinke ! |
* Add mambaforge installer (#22) * add mambaforge installer * Update README.md Co-authored-by: Nikita Titov <[email protected]> * change paths to mamba Co-authored-by: Nikita Titov <[email protected]> * Replace mambaforge with miniforge (#24) * Replace mambaforge with miniforge * Update Dockerfile Co-authored-by: James Lamb <[email protected]>
Contributes to microsoft/LightGBM#4948.
This PR proposes adding support for using
mamba
instead ofconda
to install conda packages.How I tested this
Notes for Reviewers
I'd like to push these changes to the
dev
branch, and test pulling in the new imagelightgbm/vsts-agent:ubuntu-14.04-dev
pushed to Docker Hub on microsoft/LightGBM#4953.Per microsoft/LightGBM#4948 (comment), I don't have permissions to create branches here.
@StrikerRUS could you create a
dev
branch in this repo so I can target this PR at it?@guolinke if you see this, could you please give me "write" permissions on this repo so I can add branches myself in the future?