Hyperfine: Script re-org #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculate_average_iziamos.sh
Outdated
| @@ -17,4 +17,4 @@ | |||
|
|
|||
|
|
|||
| JAVA_OPTS="--enable-preview" | |||
| time java $JAVA_OPTS --class-path target/average-1.0.0-SNAPSHOT.jar dev.morling.onebrc.CalculateAverage_iziamos | |||
| tjava $JAVA_OPTS --class-path target/average-1.0.0-SNAPSHOT.jar dev.morling.onebrc.CalculateAverage_iziamos | |||
|
Since you change all of them, maybe it would be an improvement to move them into |
|
I think you'd also like to update README.md |
|
Fixed the typo and updated the README. I'm leaving that re-org for a separate PR, to keep things manageable. Thanks a lot for reviewing, @AlexanderYastrebov. |
|
Tested with a few entries, all looking good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits up the existing launch scripts to adhere to the structure established with #182. Only to be merged once that one is in!
@hundredwatt, @AlexanderYastrebov, review welcome. This was a bit of busy work, I hope I didn't mess up anything.