Add check for FIREBASE_TOKEN existence #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warn when both token (either as input or environment variable) and service credentials are defined at the same time
guness
reviewed
Oct 18, 2022
| @@ -168,8 +168,12 @@ if [ -z "${firebase_token}" ] ; then | |||
| fi | |||
| fi | |||
|
|
|||
| if [ -n "${FIREBASE_TOKEN}" ] && [ -n "${service_credentials_file}" ]; then | |||
| echo_warn "Both authentication methods are defined: Firebase Token (via FIREBASE_TOKEN environment variable) and Service Credentials Field, one is enough." | |||
There was a problem hiding this comment.
hey, why do we have to use the uppercase one? I thought the lowercase one was already filled with the environment variable.
There was a problem hiding this comment.
We don't have to. We even shouldn't use it. However, it is still recognized by CLI and a lot of people just call the secrets like that - FIREBASE_TOKEN.
guness
pushed a commit
that referenced
this pull request
Dec 15, 2023
Warn when both token (either as input or environment variable) and service credentials are defined at the same time
guness
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Add check for FIREBASE_TOKEN existence (#48) Warn when both token (either as input or environment variable) and service credentials are defined at the same time * Addressing race condition * adding ID print so I know * removing print * Update enviornment var when using URL --------- Co-authored-by: Karol Wrótniak <[email protected]>
guness
added a commit
that referenced
this pull request
Oct 10, 2024
* Add check for FIREBASE_TOKEN existence (#48) Warn when both token (either as input or environment variable) and service credentials are defined at the same time * Skip installing firebase-tools if it exists --------- Co-authored-by: Karol Wrótniak <[email protected]> Co-authored-by: Sinan Gunes <[email protected]>
guness
added a commit
that referenced
this pull request
Oct 10, 2024
* Add check for FIREBASE_TOKEN existence (#48) Warn when both token (either as input or environment variable) and service credentials are defined at the same time * Added Firebase AD Release ID output --------- Co-authored-by: Karol Wrótniak <[email protected]> Co-authored-by: Sinan Gunes <[email protected]>
guness
added a commit
that referenced
this pull request
Oct 30, 2024
* Add check for FIREBASE_TOKEN existence (#48) Warn when both token (either as input or environment variable) and service credentials are defined at the same time * get apk url and set apk url environment --------- Co-authored-by: Karol Wrótniak <[email protected]> Co-authored-by: Sinan Gunes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn when both token (either as input or environment variable) and service credentials are defined at the same time