Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch permissions to classes and raise rather than return #98

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Switch permissions to classes and raise rather than return #98

merged 1 commit into from
Aug 30, 2022

Conversation

stevelacey
Copy link
Contributor

@stevelacey stevelacey commented Jul 13, 2022 •
edited
Loading

  • AuthenticationError for raising from views to trigger a 401
  • Partial refactor of permissions, raise exceptions, no return value
  • Move away from binding permissions to views, pass kwargs in
  • Bump coverage to 92%

@stevelacey stevelacey requested a review from wadewilliams as a code owner July 13, 2022 21:25
@stevelacey stevelacey force-pushed the refactor/permissions branch 3 times, most recently from daa2b38 to 61bb3a2 Compare July 13, 2022 21:44
@stevelacey stevelacey force-pushed the master branch 4 times, most recently from b33d804 to 81523d2 Compare August 6, 2022 11:39
@stevelacey stevelacey force-pushed the refactor/permissions branch 3 times, most recently from 2567d2d to 399a4ce Compare August 30, 2022 09:34
@stevelacey stevelacey changed the title Raise from permissions Switch permissions to classes and raise rather than return Aug 30, 2022
@stevelacey stevelacey force-pushed the refactor/permissions branch from 399a4ce to 122635c Compare August 30, 2022 13:10
@stevelacey stevelacey force-pushed the refactor/permissions branch from 122635c to 5f53c0b Compare August 30, 2022 13:15
@stevelacey stevelacey merged commit ed4195f into master Aug 30, 2022
@stevelacey stevelacey deleted the refactor/permissions branch August 30, 2022 13:18
@github-actions github-actions bot mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadewilliams wadewilliams Awaiting requested review from wadewilliams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stevelacey