Always set bundle + coerce query params #86
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the bundle always available via
GET
, currently only available on list apis, and adds coersion fortrue
/false
/null
when the bundle is derived from the query string.Note that this coercion is more strict than elsewhere given we can't assume that
string
isn't the correct type unless it's precisely these values.We can't assume that
0
/1
are bools, or that a numeric string should be anint
, but we can reasonably assume that no one wants a string"true"
/"false"
/"null"
when passing query params.What issue does this solve?
The bundle provides a selection of conveniences over using the request QueryDicts directly, so needs to be available always, life also gets a lot easier when query string bools are bools.
This makes it easier for developers to patch in arbitrary API tweaks like swapping out a serializer when a query parameter like
?nextgen=true
is passed.Checklist