Settings module + Browsable API and debug settings #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelacey
force-pushed
the
improvement/settings-module
branch
2 times, most recently
from
c3fe7ab to
85ff7ba
Compare
stevelacey
changed the title
stevelacey
changed the title
stevelacey
commented
Dec 14, 2021
| @@ -8,44 +8,32 @@ def pytest_configure(): | |||
| from django.conf import settings | |||
|
|
|||
| settings.configure( | |||
| SECRET_KEY="secret", | |||
| DEBUG=True, | |||
There was a problem hiding this comment.
Fun. This was never actually True. Seems configure cannot override the default from global_settings.
stevelacey
force-pushed
the
improvement/settings-module
branch
2 times, most recently
from
399d1ca to
3f1a175
Compare
stevelacey
force-pushed
the
improvement/settings-module
branch
from
3f1a175 to
543e994
Compare
stevelacey
commented
Dec 14, 2021
Comment on lines
-13
to
+33
| INSTALLED_APPS=[ | ||
| "django.contrib.admin", | ||
| "django.contrib.auth", | ||
| "django.contrib.contenttypes", | ||
| "django.contrib.sessions", | ||
| "django.contrib.messages", | ||
| "django.contrib.staticfiles", | ||
| "tests", | ||
| "worf", | ||
| ], | ||
| MIDDLEWARE=[ | ||
| "django.middleware.common.CommonMiddleware", | ||
| "django.contrib.sessions.middleware.SessionMiddleware", | ||
| "django.contrib.auth.middleware.AuthenticationMiddleware", | ||
| "django.contrib.messages.middleware.MessageMiddleware", | ||
| ], | ||
| ROOT_URLCONF="tests.urls", | ||
| DATABASES={ | ||
| "default": { | ||
| "ENGINE": "django.db.backends.sqlite3", | ||
| "NAME": "db.sqlite3", | ||
| } | ||
| }, | ||
| INSTALLED_APPS=[ | ||
| "django.contrib.auth", | ||
| "django.contrib.contenttypes", | ||
| "tests", | ||
| "worf", | ||
| ], | ||
| PASSWORD_HASHERS=["django.contrib.auth.hashers.MD5PasswordHasher"], | ||
| ROOT_URLCONF="tests.urls", | ||
| TEMPLATES = [ | ||
| { | ||
| "BACKEND": "django.template.backends.django.DjangoTemplates", | ||
| "APP_DIRS": True, | ||
| }, | ||
| ], | ||
| TIME_ZONE="UTC", | ||
| USE_I18N=True, | ||
| USE_L10N=True, | ||
| USE_I18N=False, | ||
| USE_L10N=False, |
There was a problem hiding this comment.
Stripped some of this down given it doesn't matter and/or saves on cpu.
stevelacey
commented
Dec 14, 2021
Comment on lines
+184
to
+188
| if settings.WORF_DEBUG: | ||
| try: | ||
| self.query = str(queryset.query) | ||
| except EmptyResultSet: | ||
| self.query = None |
There was a problem hiding this comment.
You might have seen this exception when using filters that create an impossible query. Outside of debug mode lists will yield [] but when debug mode is on they'd fail here trying to output the sql for the debug.
The reason I've addressed this here is because now that debug mode is actually on during testing, one test was failing here given it exercises an impossible query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps settings up into their own module for visibility, and adds an option to disable browsable api and debug mode.
Also switches testing to exercise debug mode, which seemingly wasn't happening (+0.5% coverage) and fixes a bug where
EmptyResultSetwould throw when trying to render the sql for the debug output.What Worf gif best describes this PR or how it makes you feel?
Checklist
READMEupdates reflecting any new features/improvements to the framework