Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign fk/m2m on create and support delete #74

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

stevelacey
Copy link
Contributor

@stevelacey stevelacey commented Nov 12, 2021

What's this PR do?

  • Expands create to support fk/m2m assignment
  • Adds support for delete with a blank 204 response
  • Adds ApiClient to worf.testing which defaults to json
  • Refactors views and tests
  • Removes transform_to_dict which does the same thing as dict
  • Bumps test coverage to 78%

Why is this important, or what issue does this solve?

I needed to create and delete things, and I wanted to do it in style 😼

What Worf gif best describes this PR or how it makes you feel?

worf_parry

Tasks

  • This PR increases test coverage
  • This PR includes README updates reflecting any new features/improvements to the framework

@stevelacey stevelacey marked this pull request as draft November 12, 2021 13:08
@stevelacey stevelacey force-pushed the improvement/full-crud branch from a2cd21c to 1ce6e82 Compare November 12, 2021 13:16
@stevelacey stevelacey marked this pull request as ready for review November 12, 2021 13:18
@stevelacey stevelacey force-pushed the improvement/full-crud branch from 1ce6e82 to 5df3375 Compare November 15, 2021 10:08
@wadewilliams
Copy link
Contributor

lol github ui to resolve conflicts creates conflicts

def serialize(self):
return {}
class CreateAPI(AssignAttributes, AbstractBaseAPI):
def create(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

method create is defined on line 23

Copy link
Contributor

@wadewilliams wadewilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 definitions for create on the create API, and I committed a merge commit (thanks github) so probably want to roll back and resolve the conflicts and I assume you want to keep only one of the create methods.

@stevelacey stevelacey force-pushed the improvement/full-crud branch from 9d0e031 to 6eede3d Compare November 16, 2021 06:03
@stevelacey stevelacey merged commit 948a358 into master Nov 16, 2021
@stevelacey stevelacey deleted the improvement/full-crud branch November 16, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants