Switch out some snake_to_camel usage for a keymap #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelacey
force-pushed
the
improvement/reduce-snake-to-camel-usage
branch
from
07b2e7d to
4bfcd5b
Compare
stevelacey
force-pushed
the
improvement/reduce-snake-to-camel-usage
branch
from
4bfcd5b to
a36c9ba
Compare
stevelacey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Switch out
snake_to_camelusage where we're attempting to recreate the name of the field the client supplied, because we know the name they supplied, and it might not be whatsnake_to_camelproduces.Also drops
whitespace_to_camelwhich seems to do the same thing assnake_to_camel(thing.replace(" ", "_").lower())and I'd rather maintain fewer casing helpers.Where should the reviewer start?
Bundle processing.
Why is this important, or what issue does this solve?
In a world where we accept complex lookups via filter params with
__in them we can't reliably camelize snake case and get the right thing out.Also, we technically support snake case, and without this change our errors will describe the fields back to the client in camel case, regardless of what they passed, which is confusing.
Tasks
READMEupdates reflecting any new features/improvements to the framework