Fix get_queryset and new tests #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelacey
force-pushed
the
bug/get-queryset-fix
branch
from
d800ab4 to
ee6d9df
Compare
regiscamimura
force-pushed
the
bug/get-queryset-fix
branch
from
ee6d9df to
258db8d
Compare
|
I merged e7a666c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
It fix the
get_querysetmethod, which would returnself.model.objects.all()if aquerysetwas set but the results were emptyWhere should the reviewer start?
The
ListAPIandDetailAPIWhy is this important, or what issue does this solve?
It would cause annotated fields to be lost and solves a security vulnerability
Definition of Done:
READMEupdates reflecting any new features/improvements to the framework