Annotation filters #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelacey
force-pushed
the
improvement/annotation-filters
branch
from
fd20417 to
cf01378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds support for generating filters automatically out of annotations applied to view querysets.
This saves client's from repeating the
filter_fieldswithin a custom filterset when they want to support filtering based on an annotation.This makes it easier to disconnect the db structure from query param filters supported by a view.
Where should the reviewer start?
Annotate some fields on a queryset then add the annotation into
filter_fields.Why is this important, or what issue does this solve?
Annotations are applied on the queryset not the model, so url_filter's ModelFilterSet doesn't introspect them by default.
What Worf gif best describes this PR or how it makes you feel?
Tasks
READMEupdates reflecting any new features/improvements to the framework